Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mandatory API key checks #639

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Remove mandatory API key checks #639

merged 5 commits into from
Jan 21, 2025

Conversation

hydra-yse
Copy link
Member

@hydra-yse hydra-yse commented Jan 4, 2025 •
edited
Loading

Closes #661.
Built on top of #637.

This PR:

  • Makes the real-time sync service optional (depending on the presence of sync_service_url) as follows:
    • Set and equal to BREEZ_SYNC_SERVICE_URL: Check for API key
    • Set and different from BREEZ_SYNC_SERVICE_URL: Use without API key
    • Not set: Disable the sync service
  • Conditionally calls rt-sync commit methods to avoid cluttering of the db when the sync service is not active
  • Skips the initial validate_api_key call unless it is set in the config

This should complete all the requirements for #554, except for the swapper proxy changes & fiat api.

@hydra-yse hydra-yse self-assigned this Jan 4, 2025
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch 2 times, most recently from cda3ef0 to b5b7d78 Compare January 4, 2025 18:49
@roeierez
Copy link
Member

roeierez commented Jan 6, 2025

@hydra-yse this needs rebase on top of the base branch.

@roeierez roeierez modified the milestone: v0.6.0 Jan 6, 2025
@hydra-yse hydra-yse changed the base branch from savage-discount-ct to main January 8, 2025 14:28
@hydra-yse hydra-yse changed the base branch from main to savage-discount-ct January 8, 2025 14:29
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch from b5b7d78 to 1fc334f Compare January 8, 2025 14:54
@roeierez roeierez added this to the Next Release milestone Jan 9, 2025
@dangeross dangeross force-pushed the savage-discount-ct branch 2 times, most recently from fadb538 to 2f7f7b3 Compare January 17, 2025 18:31
@roeierez
Copy link
Member

@hydra-yse can you rebase that so we can finalize it?

Base automatically changed from savage-discount-ct to main January 19, 2025 12:57
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch from 1fc334f to 480a867 Compare January 19, 2025 22:11
dangeross
dangeross reviewed Jan 20, 2025
View reviewed changes
cli/src/main.rs Show resolved Hide resolved
lib/core/src/persist/sync.rs Outdated Show resolved Hide resolved
lib/core/src/persist/sync.rs Outdated Show resolved Hide resolved
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch from cd3658b to 9e65c38 Compare January 20, 2025 11:05
@hydra-yse hydra-yse requested a review from dangeross January 20, 2025 11:05
dangeross
dangeross approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one typo (and needs cargo fmt)

lib/core/src/model.rs Outdated Show resolved Hide resolved
roeierez
roeierez approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roeierez roeierez modified the milestones: Next Release, v0.7.0 Jan 20, 2025
danielgranhao
danielgranhao approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch from bea9ce6 to 2519442 Compare January 21, 2025 07:05
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch from 2519442 to 69b462e Compare January 21, 2025 07:30
@hydra-yse hydra-yse merged commit 9599801 into main Jan 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgranhao danielgranhao danielgranhao approved these changes

@roeierez roeierez roeierez approved these changes

@dangeross dangeross dangeross approved these changes

Assignees

@hydra-yse hydra-yse

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Make sync url optional
4 participants
@hydra-yse @roeierez @dangeross @danielgranhao